Skip to content

Add amneziawg cable driver to using= flags - #2492

Merged
skitt merged 3 commits into
submariner-io:develfrom
sanek9:feat/amneziawg-cable-driver
Jul 27, 2026
Merged

Add amneziawg cable driver to using= flags#2492
skitt merged 3 commits into
submariner-io:develfrom
sanek9:feat/amneziawg-cable-driver

Conversation

@sanek9

@sanek9 sanek9 commented Jul 23, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Map using=amneziawg to CABLE_DRIVER=amneziawg in Makefile.inc so Shipyard deploy/E2E can select the AmneziaWG cable driver.
  • AmneziaWG is userspace (embedded amneziawg-go); no host kernel module install is required (unlike WireGuard).

Context

Companion to submariner-io/submariner#4097, which adds amneziawg to the Submariner CI E2E / flake-finder cable-driver matrix. Those jobs use shipyard/gh-actions/e2e@devel, so this change needs to land on Shipyard devel for the matrix entries to select AmneziaWG correctly (otherwise CABLE_DRIVER stays at the libreswan default).

Test plan

  • make deploy using=amneziawg (or E2E) sets CABLE_DRIVER=amneziawg / passes --cable-driver amneziawg to subctl
  • WireGuard path unchanged (using=wireguard still installs modules and sets CABLE_DRIVER=wireguard)

Made with Cursor

Summary by CodeRabbit

  • New Features
    • Added support for selecting the AmneziaWG userspace driver through the build configuration.
    • AmneziaWG can run without requiring a host kernel module.

@submariner-bot

submariner-bot commented Jul 23, 2026

Copy link
Copy Markdown

🤖 Created branch: z_pr2492/sanek9/feat/amneziawg-cable-driver

@coderabbitai

coderabbitai Bot commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bea7c1ac-07a8-442a-ab11-905f86ba4dc5

📥 Commits

Reviewing files that changed from the base of the PR and between f93811d and 6536b35.

📒 Files selected for processing (1)
  • Makefile.inc

Walkthrough

The Makefile using option parser now recognizes amneziawg, selects it as the cable driver, and documents that it uses embedded userspace amneziawg-go without requiring a host kernel module.

Changes

AmneziaWG driver selection

Layer / File(s) Summary
AmneziaWG cable driver parsing
Makefile.inc		 The using option parser recognizes amneziawg, sets CABLE_DRIVER accordingly, and documents its userspace implementation.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: mkolesnik, skitt, sridhargaddam

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding amneziawg support to the using= flag parsing.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Actionable Comments Resolved ✅ Passed PR #2492 shows only author/bot conversation and no review comments or changes requested, so there are no unresolved actionable comments.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sanek9
Add amneziawg cable driver to using= flags
6536b35 
Map using=amneziawg to CABLE_DRIVER for E2E/deploy.
Userspace driver needs no host kernel module.

Signed-off-by: sanek9 <sanya0996@gmail.com>
@sanek9
sanek9 force-pushed the feat/amneziawg-cable-driver branch from d94e78f to 6536b35 Compare July 24, 2026 00:02
@a-voitov-mitgo a-voitov-mitgo mentioned this pull request Jul 24, 2026
Merged
2 tasks
@skitt
skitt enabled auto-merge (rebase) July 24, 2026 07:53
@skitt
skitt merged commit 56805c1 into submariner-io:devel Jul 27, 2026
75 of 77 checks passed
@submariner-bot

submariner-bot commented Jul 27, 2026

Copy link
Copy Markdown

🤖 Closed branches: [z_pr2492/sanek9/feat/amneziawg-cable-driver]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skitt skitt skitt approved these changes
@tpantelis tpantelis tpantelis approved these changes
@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes
@mkolesnik mkolesnik Awaiting requested review from mkolesnik mkolesnik is a code owner
@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner
@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner
@vthapar vthapar Awaiting requested review from vthapar vthapar is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sanek9 @submariner-bot @skitt @tpantelis